Unify icon styling #2731
Merged
Unify icon styling #2731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #2731 +/- ##
=============================================
- Coverage 59.08% 56.67% -2.41%
+ Complexity 8926 8924 -2
=============================================
Files 1905 2167 +262
Lines 85277 91959 +6682
Branches 5805 6831 +1026
=============================================
+ Hits 50374 52104 +1730
- Misses 33106 37980 +4874
- Partials 1797 1875 +78 |
lukasrgr
requested changes
Sep 29, 2024
| @@ -44,6 +44,11 @@ export type Icon = { | |||
| name: string; | |||
| }; | |||
|
|
|||
| export type ImageIcon = { | |||
| src: string; | |||
| large: boolean; | |||
There was a problem hiding this comment.
not sure what you want to provide here, shouldnt this be size?
There was a problem hiding this comment.
there is only normal and large.
sfeilmeier
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.